Skip to content

[Backend] Fixed the dashboard statistics refreshing button #20803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2019
Merged

[Backend] Fixed the dashboard statistics refreshing button #20803

merged 4 commits into from
Feb 10, 2019

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jan 30, 2019 •
edited
Loading

Description (*)

This PR fixes the refresh the statistics, and provide the same approach as other buttons work (Ship Order, Reorder, etc.)

Fixed Issues (if relevant)

  1. [Backend] Dashboard Refresh Statistics action redirects to 404 #20802: [Backend] Dashboard Refresh Statistics action redirects to 404
  2. ...

Manual testing scenarios (*)

  1. Open the backend (on Dashboard)
  2. Click on the Reload Data button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from rogyar January 30, 2019 11:49
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Backend Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 30, 2019
@rogyar
Copy link
Contributor

rogyar commented Jan 30, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-20803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

rogyar
rogyar requested changes Jan 30, 2019
View reviewed changes
app/code/Magento/Backend/view/adminhtml/templates/dashboard/totalbar/refreshstatistics.phtml Outdated
@@ -8,21 +8,13 @@
<div class="page-actions-inner">
<div class="page-actions-buttons">
<?= $block->getChildHtml() ?>

<form class="action-element"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend another solution here. Removing the form and form key looks not very good considering the fact that the current approach works well on 2.2-develop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted and adjusted the implementation of RefreshStatistics controller.
Thank you.

@rogyar
Copy link
Contributor

rogyar commented Jan 30, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-20803.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4054 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 10, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit d20c863 into magento:2.3-develop Feb 10, 2019
@ghost
Copy link

ghost commented Feb 10, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 10, 2019
@sidolov
ENGCOM-4054: [Backend] Fixed the dashboard statistics refreshing button
04d97b5 
#20803
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

Labels
Area: Frontend Award: bug fix Component: Backend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@eduard13 @magento-engcom-team @rogyar @p-bystritsky