Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #21843

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Fix typo #21843

merged 2 commits into from
Mar 25, 2019

Conversation

nasanabri
Copy link
Contributor

@nasanabri nasanabri commented Mar 19, 2019 •
edited by sidolov
Loading

Fixed typo in Magento/Framework/Oauth/Oauth.php

@magento-engcom-team
Copy link
Contributor

Hi @nasanabri. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 19, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ghost ghost assigned sidolov Mar 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4536 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@nasanabri thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii soleksii self-assigned this Mar 20, 2019
@soleksii
Copy link

Not for manual testing

@nmalevanec nmalevanec self-assigned this Mar 20, 2019
@magento-engcom-team magento-engcom-team merged commit adf2d64 into magento:2.3-develop Mar 25, 2019
@ghost
Copy link

ghost commented Mar 25, 2019

Hi @nasanabri, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 25, 2019
@sidolov
ENGCOM-4536: Fix typo #21843
20a3619
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 25, 2019
@nasanabri nasanabri deleted the patch-1 branch September 29, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Cleanup Component: Oauth Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@nasanabri @magento-engcom-team @magento-cicd2 @soleksii @sidolov @nmalevanec