Skip to content

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Apr 8, 2019

Description (*)

added option to fallback to locale date format configuration.
So in case lets say in ui component xml you pass empty value you can automatically fallback to locale date format.

Fixed Issues (if relevant)

Fixes issue where ui component have hardcoded date format and when having multi site with different date formats it adds option to fallback to locale settings.
example: Have this issue with requisition lists grid in B2B in storefront.

Manual testing scenarios (*)

By default it doesn't change anything but if you change passed settings in component level and send empty value you can use locale specific settings.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

add option to fallback to locale date format configuration
@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Ui Release Line: 2.3 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner labels Apr 8, 2019
code clean up
@rogyar
Copy link
Contributor

rogyar commented Apr 9, 2019

Hi @Karlasa. Thank you for your contribution. Would you provide a little bit more information about the use case:

Fixes issue where ui component have hardcoded date format and when having multi site with different date formats it adds option to fallback to locale settings.

So, if an UI component has a hardcoded date format, the following check https://github.com/magento/magento2/pull/22213/files#diff-8c266c07ae31f60348f20567f5fa5d92R29
does not override the hardcoded value. So a value from locale won't count.

Thank you.

@rogyar rogyar self-assigned this Apr 9, 2019
@Karlasa
Copy link
Contributor Author

Karlasa commented Apr 9, 2019

@rogyar
I will use it with patch where I remove UI component setting value (as it's not possible to remove under theme)
example like this:

Screen Shot 2019-04-09 at 14 44 42

Just figured that it would be good to have this option if anyone will be going to create something new with those components :)

@ghost ghost assigned sidolov Jun 19, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5323 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @Karlasa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 5, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Ui Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants