-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Date column ui component locale date format #22213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date column ui component locale date format #22213
Conversation
add option to fallback to locale date format configuration
Hi @Karlasa. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
code clean up
Hi @Karlasa. Thank you for your contribution. Would you provide a little bit more information about the use case:
So, if an UI component has a hardcoded date format, the following check https://github.com/magento/magento2/pull/22213/files#diff-8c266c07ae31f60348f20567f5fa5d92R29 Thank you. |
@rogyar Just figured that it would be good to have this option if anyone will be going to create something new with those components :) |
Hi @sidolov, thank you for the review.
|
✔️ QA passed |
Hi @Karlasa, thank you for your contribution! |
Description (*)
added option to fallback to locale date format configuration.
So in case lets say in ui component xml you pass empty value you can automatically fallback to locale date format.
Fixed Issues (if relevant)
Fixes issue where ui component have hardcoded date format and when having multi site with different date formats it adds option to fallback to locale settings.
example: Have this issue with requisition lists grid in B2B in storefront.
Manual testing scenarios (*)
By default it doesn't change anything but if you change passed settings in component level and send empty value you can use locale specific settings.
Contribution checklist (*)