Skip to content

code cleanup (http to https) #22526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2019
Merged

code cleanup (http to https) #22526

merged 3 commits into from
May 1, 2019

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Apr 28, 2019 •
edited
Loading

Description (*)

code cleanup (http to https)

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2019

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch self-requested a review April 28, 2019 12:34
@dmytro-ch dmytro-ch self-assigned this Apr 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4836 has been created to process this Pull Request

dmytro-ch
dmytro-ch requested changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ravi-chandra3197,
thank you for your contribution!

Could you please also apply the same changes for other URLs like:
http://docs.magento*
There are around 20 occurrences.

@ravi-chandra3197
Copy link
Contributor Author

Hello @dmytro-ch,
I have updated PR as per your suggestion, can you review it.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4836 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 30, 2019
@Nazar65 Nazar65 self-assigned this Apr 30, 2019
@soleksii
Copy link

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit f900e10 into magento:2.3-develop May 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 1, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 1, 2019
@sidolov
ENGCOM-4836: code cleanup (http to https) #22526
d7ac4f6
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@Nazar65 Nazar65

@dmytro-ch dmytro-ch

@soleksii soleksii

Labels
Area: Frontend Cleanup Component: Backend Component: Braintree Component: Catalog Component: CatalogRule Component: Customer Component: Paypal Component: SalesRule Component: Search Component: Tax Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ravi-chandra3197 @magento-engcom-team @soleksii @dmytro-ch @Nazar65