Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2019

Description (*)

I have removed the code which was making the Asterisk(*) to come up on left rather on the right side as in other fields and also on "Add New Address" on the frontend.

Fixed Issues (if relevant)

  1. Asterisk(*) sign position does not consistent in admin #22638: Asterisk(*) sign position does not consistent in admin

Manual testing scenarios (*)

  1. Go to admin
  2. Sales > Orders
  3. Create new order > Create new customer
  4. Review the asterisk(*) sign position
  5. Now it is on the right side

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 9, 2019

Hi @sanjaychouhan-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-5344 has been created to process this Pull Request
✳️ @miguelbalparda, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @sanjaychouhan-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 26, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 26, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants