magento/magento2#22870: ProductRepository fails to update an existing product with a changed SKU. #22933

p-bystritsky · 2019-05-17T12:52:26Z

Description (*)

Fixed Issues (if relevant)

ProductRepository fails to update an existing product with a changed SKU #22870: ProductRepository fails to update an existing product with a changed SKU.

Manual testing scenarios (*)

See issue description.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-05-17T12:52:28Z

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

rogyar · 2019-05-18T13:46:15Z

dev/tests/integration/testsuite/Magento/Catalog/Model/ProductRepositoryTest.php

+        $this->productRepository->save($initialProduct);
+
+        $updatedProduct = Bootstrap::getObjectManager()->create(Product::class);
+        $updatedProduct->load($productId);


Please, avoid using deprecated methods.
For loading a model, use a resource model and product model factory. So in result we have something like:

Suggested change

$updatedProduct->load($productId);

// ProductResource is alias for \Magento\Catalog\Model\ResourceModel\Product

// ProductFactory is alias for \Magento\Catalog\Model\ProductFactory

$productFactory = Bootstrap::getObjectManager()->get(ProductFactory::class)

$updatedProduct = $productFactory->create()

$productResource = Bootstrap::getObjectManager()->get(ProductResource::class)

$productResource->load($updatedProduct, $productId)

@rogyar updated.

…with a changed SKU.

ihor-sviziev

Hi @p-bystritsky,
In general changes looks good. Could you review my suggestions? We don't need to have code duplication

app/code/Magento/Catalog/Model/ProductRepository.php

p-bystritsky · 2019-05-27T14:09:55Z

Hi @p-bystritsky,
In general changes looks good. Could you review my suggestions? We don't need to have code duplication

@ihor-sviziev, thank you. Your suggestions committed.

ihor-sviziev

Hi @p-bystritsky,
Could you check failing tests? Looks like your change broke some functionality
PS: very strange that we hadn’t these fails before fixing static tests, it it might be just coincidence

Co-Authored-By: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>

p-bystritsky · 2019-05-29T14:02:42Z

@ihor-sviziev fixed.

magento-engcom-team · 2019-05-29T15:52:40Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5134 has been created to process this Pull Request

soleksii · 2019-05-30T10:52:37Z

✔️ QA Passed

Before:

After:

magento-engcom-team · 2019-05-31T11:13:40Z

Hi @rogyar, thank you for the review.
ENGCOM-5134 has been created to process this Pull Request

m2-assistant · 2019-06-13T02:23:41Z

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…oduct with a changed SKU. #22933

magento-engcom-team added Component: Catalog Release Line: 2.3 labels May 17, 2019

p-bystritsky added the Progress: needs update label May 17, 2019

rogyar self-assigned this May 18, 2019

rogyar requested changes May 18, 2019

View reviewed changes

p-bystritsky force-pushed the ISSUE-22870 branch from a1463eb to 6d359a3 Compare May 21, 2019 09:46

magento#22870: ProductRepository fails to update an existing product …

70a3adf

…with a changed SKU.

p-bystritsky force-pushed the ISSUE-22870 branch from 6d359a3 to 70a3adf Compare May 21, 2019 12:33

p-bystritsky removed the Progress: needs update label May 21, 2019

p-bystritsky requested a review from rogyar May 22, 2019 12:49

ihor-sviziev requested changes May 24, 2019

View reviewed changes

ghost assigned ihor-sviziev May 24, 2019

ghost added the Progress: needs update label May 24, 2019

ihor-sviziev requested changes May 28, 2019

View reviewed changes

magento#22933: Apply suggestions from code review

d9282d8

Co-Authored-By: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>

p-bystritsky force-pushed the ISSUE-22870 branch from 59f22a1 to d9282d8 Compare May 29, 2019 14:01

ihor-sviziev approved these changes May 29, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels May 29, 2019

soleksii self-assigned this May 30, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels May 30, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels May 30, 2019

Nazar65 self-assigned this May 30, 2019

ghost added Progress: accept and removed Progress: extended testing labels May 30, 2019

rogyar approved these changes May 31, 2019

View reviewed changes

magento-engcom-team added the Award: bug fix label Jun 10, 2019

magento-engcom-team merged commit d9282d8 into magento:2.3-develop Jun 13, 2019

magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2019

ENGCOM-5134: #22870: ProductRepository fails to update an existing pr…

5f0573f

…oduct with a changed SKU. #22933

magento-engcom-team added this to the Release: 2.3.3 milestone Jun 13, 2019

magento-engcom-team mentioned this pull request Jun 21, 2019

ProductRepository fails to update an existing product with a changed SKU #22870

Closed

sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

magento/magento2#22870: ProductRepository fails to update an existing product with a changed SKU. #22933

magento/magento2#22870: ProductRepository fails to update an existing product with a changed SKU. #22933

Uh oh!

p-bystritsky commented May 17, 2019

Uh oh!

m2-assistant bot commented May 17, 2019

Uh oh!

rogyar May 18, 2019

Uh oh!

p-bystritsky May 21, 2019

Uh oh!

ihor-sviziev left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

p-bystritsky commented May 27, 2019

Uh oh!

ihor-sviziev left a comment •

edited

Loading

Uh oh!

p-bystritsky commented May 29, 2019

Uh oh!

magento-engcom-team commented May 29, 2019

Uh oh!

soleksii commented May 30, 2019

Uh oh!

magento-engcom-team commented May 31, 2019

Uh oh!

m2-assistant bot commented Jun 13, 2019

Uh oh!

Uh oh!

-        $updatedProduct->load($productId);
+    // ProductResource is alias for \Magento\Catalog\Model\ResourceModel\Product
+    // ProductFactory is alias for \Magento\Catalog\Model\ProductFactory
+    $productFactory =  Bootstrap::getObjectManager()->get(ProductFactory::class)
+    $updatedProduct = $productFactory->create()
+    $productResource = Bootstrap::getObjectManager()->get(ProductResource::class)
+    $productResource->load($updatedProduct, $productId)

magento/magento2#22870: ProductRepository fails to update an existing product with a changed SKU. #22933

magento/magento2#22870: ProductRepository fails to update an existing product with a changed SKU. #22933

Uh oh!

Conversation

p-bystritsky commented May 17, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 17, 2019

Uh oh!

rogyar May 18, 2019

Choose a reason for hiding this comment

Uh oh!

p-bystritsky May 21, 2019

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

p-bystritsky commented May 27, 2019

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

p-bystritsky commented May 29, 2019

Uh oh!

magento-engcom-team commented May 29, 2019

Uh oh!

soleksii commented May 30, 2019

Uh oh!

magento-engcom-team commented May 31, 2019

Uh oh!

m2-assistant bot commented Jun 13, 2019

Uh oh!

Uh oh!

ihor-sviziev left a comment •

edited

Loading