Skip to content

WIP: Upgrade PHPUnit #23225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: Upgrade PHPUnit #23225

wants to merge 2 commits into from

Conversation

kassner
Copy link
Contributor

@kassner kassner commented Jun 12, 2019

Work in progress

Description

Given Magento 2.3 supports only PHP 7.1+, we can upgrade PHPUnit to a supported version. This PR is an attempt to gather what is needed for this upgrade to be successful.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2019

Hi @kassner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassner I believe this will be done by core team at appropriate moment and cannot be done via GitHub due to lack of b2b/ee code access.

@buskamuza what do you think?

@buskamuza
Copy link
Contributor

Actually, based on PHPUnit changelog, I don't think this upgrade impacts tests themselves. So the important part is fixing the framework (listeners) as it's done in this PR.
But core team (or somebody with access to ee/b2b code) is still needed to verify that no tests are broken indeed.

@sivaschenko
Copy link
Member

Thanks for the nice initiative @kassner !

I think there might be a problem with https://github.com/magento/mtf as phpunit-selenium 4.1 (current dependency) does not support PHPUnit 7. So we might need to update MTF first.

@okolesnyk what do you think?

@orlangur
Copy link
Contributor

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.
Thanks for collaboration!

@orlangur orlangur closed this Aug 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2019

Hi @kassner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kassner kassner deleted the patch-21 branch January 29, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants