Skip to content

Fixed #23238 Apply button act like remove button while create new order from admin #23250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

Fixed #23238 Apply button act like remove button while create new order from admin #23250

merged 1 commit into from
Jun 19, 2019

Conversation

gaurav-473
Copy link
Contributor

Fixed #23238 Apply button act like remove button while create new order from admin

Preconditions (*)

magento 2.3

Steps to reproduce (*)

  1. Go to Admin -> Create New Order
  2. Select customer and add product
  3. Apply valid coupon
  4. Now click apply button again

Expected result (*)

Coupon should not be removed.

Actual result (*)

apply button issue

@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2019

Hi @gauravagarwal1001. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gaurav-473 gaurav-473 requested a review from davidalger June 14, 2019 00:28
@gaurav-473
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001, here is your new Magento instance.
Admin access: https://pr-23250.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned aleron75 Jun 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-5292 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Jun 14, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Jun 14, 2019
Den4ik
Den4ik requested changes Jun 19, 2019
View reviewed changes
app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml
<input type="text" class="admin__control-text" id="coupons:code" value="" name="coupon_code" />
<?= $block->getButtonHtml(__('Apply'), 'order.applyCoupon($F(\'coupons:code\'))') ?>
<?php endif; ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified with
if() { } else { }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also may be make sense to do something like coupon form in cart: disabled input + button
rqlno_2019-06-19_21-33-01

@magento-engcom-team magento-engcom-team mentioned this pull request Jun 19, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 6f5fc6e into magento:2.3-develop Jun 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2019
@VladimirZaets
ENGCOM-5292: Fixed #23238 Apply button act like remove button while c…
d270e3e 
…reate new order from admin #23250
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 19, 2019
@krishprakash krishprakash mentioned this pull request Jun 20, 2019
Merged
@VladimirZaets VladimirZaets added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik requested changes

@davidalger davidalger Awaiting requested review from davidalger

+1 more reviewer

@aleron75 aleron75 aleron75 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@aleron75 aleron75

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Community Insider: Cedcommerce community-insider-contribution Component: Sales Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.

Apply coupon button act like remove coupon while create new order from admin
8 participants
@gaurav-473 @magento-engcom-team @engcom-Delta @Den4ik @aleron75 @VladimirZaets @p-bystritsky @engcom-Foxtrot