magento/magento-2#23222: setup:upgrade should return failure when app…

[ProcessEight]

app:config:import failed: Added logic to throw RuntimeException if app:config:import returns failure error code

This PR adds logic which detects if the return code of the app:config:import command returns an error code greater than zero and if so, throws a RuntimeException.

Description (*)

These CLI commands are used for deployments. If there is an error on deployment, the command should stop. But without an error code we cannot stop. This PR adds the error code.

Fixed Issues (if relevant)

1. setup:upgrade should return failure when app:config:import failed #23222: setup:upgrade should return failure when app:config:import failed

Manual testing scenarios (*)

1. Add an Exception to Magento\Deploy\Console\Command\App\ConfigImport\Processor
   after Line 114

 if (!$importers || !$this->changeDetector->hasChanges()) {
              throw new \Exception('Test'); // added line

2. Run bin/magento setup:upgrade
3. Verify that the bin/magento setup:upgrade command is terminated by the RuntimeException

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ProcessEight. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ihor-sviziev]

Hi @ProcessEight,
Could you cover your change with test in order not to make regression there in future?

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5395 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @ProcessEight, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.