Skip to content

#23354 : Data saving problem error showing when leave blank qty and update it #23360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

#23354 : Data saving problem error showing when leave blank qty and update it #23360

merged 1 commit into from
Jul 5, 2019

Conversation

konarshankar07
Copy link
Contributor

Description (*)

Error message added if qty field left empty when qty is updated in multishipping.

Fixed Issues (if relevant)

  1. Data saving problem error showing when leave blank qty and update it #23354 : Data saving problem error showing when leave blank qty and update it

Manual testing scenarios (*)

  1. Front end -> Login into account
  2. Add more than 2 products to the cart
  3. From cart go to checkout with multiple addresses
  4. Qty leave blank and click on Update Qty & Addresses
  5. Error message "Qty field cannot be empty"

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2019

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur
orlangur requested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add client side validation instead and remove this one.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

@ghost ghost assigned orlangur Jun 21, 2019
orlangur
orlangur requested changes Jun 22, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @konarshankar07, I meant a validation on JavaScript side - required-entry rule or something.

@konarshankar07
Copy link
Contributor Author

Hello @orlangur
Sorry, my bad. I'll update the code.
Thanks

@konarshankar07 konarshankar07 requested a review from orlangur June 22, 2019 13:03
orlangur
orlangur requested changes Jun 22, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konarshankar07 great, looks perfect now!

Please squash changes into a single commit so that we have perfectly clean history 😉

@konarshankar07
Added data validation for the input box (+3 squashed commit)
471fd85 
Squashed commit:

[1a39c41fdfe] Added clientside validation

[b3f97d9a78d] Added PHP Doc block for class

[fdb75fff538] error message added if qty is left empty
@konarshankar07 konarshankar07 force-pushed the data_save_issue_23354 branch from 5206fe5 to 471fd85 Compare June 22, 2019 14:36
@konarshankar07
Copy link
Contributor Author

Hello @orlangur

As per your request, I squashed all my commit and now getting an error in automated testing. Can you please help me out to fix this?

Thanks

@konarshankar07 konarshankar07 requested a review from orlangur June 23, 2019 09:10
@konarshankar07
Copy link
Contributor Author

Hello @orlangur ,

Do you still have any queries with this pull request?

Thanks

@ghost ghost assigned sivaschenko Jul 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5398 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jul 4, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jul 4, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team magento-engcom-team mentioned this pull request Jul 5, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 471fd85 into magento:2.3-develop Jul 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 5, 2019
magento-engcom-team pushed a commit that referenced this pull request Jul 5, 2019
@sidolov
ENGCOM-5398: #23354 : Data saving problem error showing when leave bl…
b45a357 
…ank qty and update it #23360
@krishprakash krishprakash mentioned this pull request Jul 8, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@orlangur orlangur Awaiting requested review from orlangur

Assignees

@orlangur orlangur

@sivaschenko sivaschenko

@engcom-Alfa engcom-Alfa

Labels
Area: Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Component: Multishipping Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@konarshankar07 @magento-engcom-team @engcom-Alfa @orlangur @sivaschenko