magento/magento2#23386: Copy Service does not work properly for Entities which extends Data Object and implements ExtensibleDataInterface.

[swnsma]

Provide fallback to copy Extension Attributes for classes which extends Data Object.

Fixed Issues

1. Copy Service does not works properly for Entities which extends Data Object and implements ExtensibleDataInterface #23386: Copy Service does not works properly for Entities which extends Data Object and implements ExtensibleDataInterface

Manual testing scenarios

See in issue.

[m2-assistant]

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-5352 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[aleron75]

@swnsma do you think that the unit test related to the updated class should be updated to reflect the change in fallback logic or is it already ok?

Not sure if changes require coverage by auto-tests

[swnsma]

Hi @aleron75,

I think the best is to cover this behavior with Integration Tests.
But due to this is no easy way to cover it due to Extension Attribute usage I prefer to skip it.

But I can try if you can share an example of how test can looks like.

E.G.
Source: Quote
Field: Extension Attribute -> Shipping Assignment
Target: ?
Field: Extension Attribute -> ?

[aleron75]

Hello @swnsma, I asked because I see there is already a unit test covering the class, it' \Magento\Framework\DataObject\Test\Unit\CopyTest so it would enough to take a look at that unit test and consider if it already covers the scenarios you extended or if it needs to be extended. That could be enough I think. Thanks!

[swnsma]

Hi @aleron75,
I have updated unit tests!

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-5352 has been created to process this Pull Request

[m2-assistant]

Hi @swnsma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.