Skip to content

Conversation

geet07
Copy link

@geet07 geet07 commented Jun 25, 2019

Description (*)

Mini cart loader not working first time magento2

Fixed Issues (if relevant)

  1. Mini cart loader not working first time magento2 #23377: Mini cart loader not working first time magento2

Manual testing scenarios (*)

  1. Clear browser cache and open website when clicking on add to cart see on the mini cart. First-time mini cart loader is showing.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 25, 2019

Hi @geet07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned sidolov Jun 25, 2019
@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jun 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5357 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@geet07 geet07 added Partner: Ranosys Pull Request is created by Ranosys Technologies partners-contribution Pull Request is created by Magento Partner labels Jun 26, 2019
@engcom-Foxtrot engcom-Foxtrot self-assigned this Jun 26, 2019
@magento-engcom-team magento-engcom-team merged commit 3d6b783 into magento:2.3-develop Jun 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2019

Hi @geet07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Component: Checkout Partner: Ranosys Pull Request is created by Ranosys Technologies partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants