Skip to content

Conversation

sunilit42
Copy link
Contributor

@sunilit42 sunilit42 commented Jul 1, 2019

Preconditions (*)
Magento CE 2.2.9

Fixed Issues (if relevant)
#23510

Steps to reproduce ()
Create a product with a customizable option field of type Area
When placing an order for that product fill that Area type field with multiple lines of text
Look at the new order in Admin Dashboard
Expected result (
)
The text of the field value of Area type is rendered with respect of each line (each line of next is on new line)

Actual result (*)
The value of product customizable option field of type Area is rendered with HTML
tag inside

@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2019

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sunilit42 sunilit42 changed the title remove html tag from option html from order page remove html tag from option html from order page #23510 Jul 1, 2019
@sunilit42 sunilit42 changed the title remove html tag from option html from order page #23510 remove html tag from option html from order page Jul 1, 2019
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sunilit42 thanks for the pull request! Please take a look at my question in a review comment

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5435 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jul 12, 2019
@engcom-Delta engcom-Delta self-assigned this Jul 15, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 19, 2019

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants