Skip to content

Conversation

krishprakash
Copy link

@krishprakash krishprakash commented Jul 5, 2019

Original Pull Request

#23306

Description (*)

Preconditions (*)

  • Product with Any Decimal Quantity should be added in Cart If Decimal "Qty Uses Decimals" and
    option is "Yes"
  • Product is not adding in cart with qty decimal, qty increment is enabled and minimum qty assigned.

Fixed Issues (if relevant)

#23038

Manual testing scenarios (*)

1 Create simple product enable "Qty Uses Decimal" and Assign "Minimum Qty" to 0.5 then enable "Enable Qty Increments" and assign 0.1 to "Qty Increments"
Here is the case Minimum Qty in Cart 0.5, Qty Increment Is 0.1

2 Try to add it on Cart
"You can buy this product only in quantities of 0.1 at a time" error message

@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krishprakash krishprakash changed the title [Backport] FS/23038 Decimal qty with Increment is with specific values are not adding in cart [Backport] #23038 Decimal qty with Increment is with specific values are not adding in cart Jul 5, 2019
@rogyar rogyar self-assigned this Jul 5, 2019
@rogyar rogyar added Port Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jul 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5400 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 5, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants