Skip to content

Moved Zero Subtotal Checkout Payment Settings #23679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2019
Merged

Moved Zero Subtotal Checkout Payment Settings #23679

merged 2 commits into from
Jul 27, 2019

Conversation

textarea
Copy link
Contributor

@textarea textarea commented Jul 12, 2019

Description (*)

"Zero Subtotal Checkout" payment method settings disappear if "Offline Payments" module is disabled.

Fixed Issues (if relevant)

  1. Can't see "Zero Subtotal Checkout" payment method settings if "Offline Payments" module is disabled #23678: Can't see "Zero Subtotal Checkout" payment method settings if "Offline Payments" module is disabled

Manual testing scenarios (*)

  1. php bin/magento module:disable Magento_OfflinePayments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 12, 2019

Hi @textarea. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 12, 2019

CLA assistant check
All committers have signed the CLA.

@sidolov
Copy link
Contributor

sidolov commented Jul 15, 2019

Hi @textarea , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

@textarea
Copy link
Contributor Author

Hi @sidolov , email added. Thanks.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5452 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@orlangur orlangur added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 16, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jul 17, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the related translation from OfflinePayments to Payment module as well

@textarea
Copy link
Contributor Author

Done, thanks.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5452 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2019

Hi @textarea, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants