Fixed issue #23575 #23699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

magento-engcom-team merged 3 commits into magento:2.3-develop from syed92hasan:fix-23575

Aug 12, 2019

Contributor

syed92hasan commented Jul 15, 2019

Description (*)

Created date mismatch with a calendar icon

Fixed Issues (if relevant)

Created date mismatch with calendar icon #23575: Created date mismatch with a calendar icon

Manual testing scenarios (*)

Admin -> Marketing -> User Contents -> Reviews
Select created date

Before Update Result

After Update Result

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)


          Fixed issue magento#23575

35ca49e

m2-assistant bot commented Jul 15, 2019

Hi @syed92hasan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-engcom-team added Area: Design/Frontend Component: Review Release Line: 2.3 Partner: Ranosys Technologies partners-contribution labels

syed92hasan self-assigned this

ghost unassigned syed92hasan

ghost commented Jul 15, 2019

@syed92hasan unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

syed92hasan self-assigned this

ghost unassigned syed92hasan

ghost commented Jul 15, 2019

@syed92hasan unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

syed92hasan self-assigned this

ghost unassigned syed92hasan

ghost commented Jul 15, 2019

@syed92hasan unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

syed92hasan self-assigned this

ghost unassigned syed92hasan

ghost commented Jul 15, 2019

@syed92hasan unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

syed92hasan self-assigned this

ghost unassigned syed92hasan

ghost commented Jul 15, 2019

@syed92hasan unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

kalpmehta approved these changes

View reviewed changes

ghost assigned kalpmehta

ghost added the Progress: ready for testing label

Contributor

magento-engcom-team commented Jul 16, 2019

Hi @kalpmehta, thank you for the review.
ENGCOM-5459 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

Contributor

magento-engcom-team commented Jul 16, 2019

@syed92hasan thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Contributor Author

syed92hasan commented Jul 17, 2019

@syed92hasan thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Hi @magento-engcom-team ,

Done

engcom-Alfa self-assigned this

ghost removed the Progress: ready for testing label

ghost added the Progress: testing in progress label

Contributor

engcom-Alfa commented Jul 17, 2019

✔️ QA Passed

Before:

After:

ghost added Progress: extended testing and removed Progress: testing in progress labels

engcom-Foxtrot self-assigned this

engcom-Foxtrot added 2 commits

July 19, 2019 12:03


          Merge remote-tracking branch 'mainline/2.3-develop' into fix-23575

aa1db91


          magento#23699: Static tests fix.

3aaedfd

engcom-Foxtrot force-pushed the fix-23575 branch from f64d683 to 3aaedfd Compare

July 19, 2019 09:04

ghost added Progress: accept and removed Progress: extended testing labels

Member

sivaschenko commented Jul 22, 2019

Static test fail is not valid. See the sniff fix here: #23790

magento-engcom-team merged commit 3aaedfd into magento:2.3-develop

m2-assistant bot commented Aug 12, 2019

Hi @syed92hasan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request


          ENGCOM-5459: Fixed issue #23575 #23699

magento-engcom-team added this to the Release: 2.3.4 milestone

VladimirZaets added the Auto-Tests: Not Required label

krzksz mentioned this pull request

Created date mismatch with calendar icon #23575

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Auto-Tests: Not Required Component: Review Partner: Ranosys Technologies partners-contribution Progress: accept Release Line: 2.3