Skip to content

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Jul 16, 2019

Description (*)

#23624: Resolve [Authorize.net accept.js] "Place Order" button not being disabled when editing billing address

Reason: Template app/code/Magento/AuthorizenetAcceptjs/view/frontend/web/template/payment/authorizenet-acceptjs.html doesn't have the code to disable Place Order button.

Solution: Need to add the code: css="disabled: !isPlaceOrderActionAllowed()" to the template of AuthorizenetAcceptjs Payment.

Fixed Issues (if relevant)

  1. [Authorize.net accept.js] "Place Order" button not being disabled #23624: [Authorize.net accept.js] "Place Order" button not being disabled

Manual testing scenarios (*)

  1. Configure and setup authorize.net accept js payment method
  2. Place non-free item in cart
  3. Proceed to checkout.
  4. Enter shipping information and proceed to the billing step.
  5. Use Authorize.net accept js payment method.
  6. Uncheck "My billing and shipping address are the same"
  7. Fill out billing information + card details but don't hit the "update" button
  8. Results : The place order button at the bottom should be disabled as long as billing information is not updated (Similiar to how the old authorize.net extension, the brain tree extension and the paypal extension work) => It prevents the user placing order without Update billing address.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Stepa4man
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, here is your new Magento instance.
Admin access: https://pr-23718.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong, Thanks for your contribution!

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-5451 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 23, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants