Skip to content

Conversation

rickkuilman
Copy link
Contributor

Description (*)

Removed redundant whitespace so that the custom option value can be copied as a whole, instead of having to remove the whitespace every time.

A gif says more than 1000 words, before situation:

before

And after the fix:

after

Fixed Issues (if relevant)

Manual testing scenarios (*)

Add a custom option to a product, long enough that it will be cut off (the dots show up) and hover over the dots. See gifs in description.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • [] All automated tests passed successfully (all builds are green)

Removed redundant whitespace so that the custom option value can be copied as a whole, instead of having to remove the whitespace every time.
@m2-assistant
Copy link

m2-assistant bot commented Jul 24, 2019

Hi @rickkuilman. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 24, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5580 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@rickkuilman
Copy link
Contributor Author

I've updated the failing test accordingly to the change in functionality that I made. This should fix the failing test (:

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Aug 20, 2019

Hi @rickkuilman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 20, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants