-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Removed redundant whitespace from order options #23867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed redundant whitespace from order options #23867
Conversation
Removed redundant whitespace so that the custom option value can be copied as a whole, instead of having to remove the whitespace every time.
Hi @rickkuilman. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review.
|
I've updated the failing test accordingly to the change in functionality that I made. This should fix the failing test (: |
✔️ QA passed |
@magento run all tests |
Hi @rickkuilman, thank you for your contribution! |
Description (*)
Removed redundant whitespace so that the custom option value can be copied as a whole, instead of having to remove the whitespace every time.
A gif says more than 1000 words, before situation:
And after the fix:
Fixed Issues (if relevant)
Manual testing scenarios (*)
Add a custom option to a product, long enough that it will be cut off (the dots show up) and hover over the dots. See gifs in description.
Questions or comments
Contribution checklist (*)