Skip to content

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Jul 24, 2019

Description (*)

This PR provide fix for verification of selected custom options

Fixed Issues (if relevant)

  1. Can't add product to cart with customizable options (type checkbox) through REST API #23863: Can't add product to cart with customizable options (type checkbox) through REST API

Manual testing scenarios (*)

  1. Add product with 2 and more selected custom options to cart via api

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 24, 2019

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5525 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@swnsma swnsma added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jul 31, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jul 31, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Aug 6, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Aug 6, 2019
@sidolov sidolov modified the milestones: Release: 2.3.3, Release: 2.3.4 Aug 6, 2019
@Den4ik Den4ik deleted the bug/multiselect-options-verification branch September 19, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants