Skip to content

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Jul 26, 2019

Description (*)

  1. No auto-focus after validation at "Create Configurations" button => User can not see the error message #23904: Resolve No auto-focus after validation at "Create Configurations" button => User can not see the error message

Solution: Check if validation is false, call the function this.form().focusInvalid(); at app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/components/modal-configurable.js

Fixed Issues (if relevant)

  1. No auto-focus after validation at "Create Configurations" button => User can not see the error message #23904: No auto-focus after validation at "Create Configurations" button => User can not see the error message

Manual testing scenarios (*)

  1. Go to Catalog->Products
  2. Add Products
  3. Scroll to Create Configurations
    image
  4. Click the button Create Configurations
    Expected result: Validate: Invalid, auto focus to the error fields

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…ton => User can not see the error message issue23904
@m2-assistant
Copy link

m2-assistant bot commented Jul 26, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-5512 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-requested a review July 30, 2019 07:54
@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 30, 2019
@engcom-Foxtrot engcom-Foxtrot removed their request for review July 30, 2019 07:55
@edenduong edenduong removed the request for review from Stepa4man July 30, 2019 08:10
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 1, 2019
…urations" button => User can not see the error message issue23904 magento#23905
@magento-engcom-team magento-engcom-team merged commit 039ea77 into magento:2.3-develop Aug 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Aug 1, 2019
@edenduong
Copy link
Contributor Author

@sivaschenko : Could I receive Bug fixed reward? Thank you :)

@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants