Resolve Missing Validation at some Payment Method Settings issue 23916

[edenduong]

Description (*)

1. Resolve Missing Validation at some Payment Method Settings #23916: Missing Validation at some Payment Method Settings

Solution: Add the validate tag into the system.xml file

Fixed Issues (if relevant)

1. Missing Validation at some Payment Method Settings #23916: Missing Validation at some Payment Method Settings

Manual testing scenarios (*)

1. Go to Store->Configurations->Sales->Payment Method
2. Find these fields:

• Check/Money Order
  • Minimum Order Total
  • Maximum Order Total
• Bank Transfer Payment
  • Minimum Order Total
  • Maximum Order Total
  • Sort Order
• Cash On Delivery Payment
  • Minimum Order Total
  • Maximum Order Total
  • Sort Order
• Purchased Order
  • Minimum Order Total
  • Maximum Order Total
• Authorize.Net Direct Post (Deprecated)
  • Minimum Order Total
  • Maximum Order Total
• Authorize.Net
  • Minimum Order Total
  • Maximum Order Total

3. Fill string "one" to the fields
4. Save

Expected result: Can not save because it is not number

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[edenduong]

@magento give me test instance

[magento-engcom-team]

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-23917.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-5504 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA passed

[fooman]

Does validate-number validate-zero-or-greater allow an empty field? Reason I am asking is that otherwise any change to any payment method could now require someone to manually input all those zeroes (even on inactive payment methods) before being able to save the page.

[edenduong]

Does validate-number validate-zero-or-greater allow an empty field? Reason I am asking is that otherwise any change to any payment method could now require someone to manually input all those zeroes (even on inactive payment methods) before being able to save the page.

@fooman Yes. You can leave them empty and save. No problem. It only validates when the user enter the data but it is not a number.

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[edenduong]

@sivaschenko : Could I receive Bug fixed reward? Thank you :)