issue/24043: add better exception handling for cli commands

[PascalBrouwers]

Description (*)

Fixed Issues (if relevant)

1. Better exception handling during cli commands #24043: Better exception handling during cli commands

Manual testing scenarios (*)

1. Have a module with a wrong path in registration.php. For example set the path in vendor/magento/module-catalog/registration.php to DIR . '/wrong_folder'
2. Run bin/magento setup:upgrade
3. See that it shows the actual exception (error with module registration)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @PascalBrouwers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

Hi @PascalBrouwers. Thank you for your contribution. Please, check the failing integration tests

[PascalBrouwers]

All failures in the tests have nothing to do with the changes in this PR.

[PascalBrouwers]

@rogyar All failures in the tests have nothing to do with the changes in this PR. So either fix the tests or ignore the messages.

[rogyar]

Hi @PascalBrouwers. Please, take a look at the following test https://testing-service.magento-community.engineering/reports/magento/magento2/pull/24044/411a2007-03b1-44f0-857d-48083f80b119/26357/Integration/allure-report-ce/index.html#suites/69ab40e7d96841d93275d46d2aeb2a4f/921cbff04d53dd04/
which have an assertion for the CLI output. Since we have expanded the information that is being shown once an error appeared, the assertion fails.

Also, please note that in case if we have an exception upon invoking parent::doRun(https://github.com/magento/magento2/pull/24044/files#diff-4eb287b4e24c054a400e5f7b40dab0cbR105-R107), eventually the $exitCode will be undefined. However, we need a value since we use it for return.

[PascalBrouwers]

Ok, i'll make sure the variable exitCode is defined.

[PascalBrouwers]

Hmm, the static test is mentioning:
array_merge(...) is used in a loop and is a | | resources greedy construction
But I'm not using array_merge.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5621 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @PascalBrouwers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[PascalBrouwers]

Thank you! Filled in the survey. Took a few tries to be able to login though.