-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Resolve Wrong Label when create new "Attribute Set" (issue 24147) #24148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Wrong Label when create new "Attribute Set" (issue 24147) #24148
Conversation
Hi @edenduong. Thank you for your contribution
In case you'd like to rerun tests use the following comments:
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edenduong,
Thanks for your contribution.
app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Main/Formset.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment.
Hi @Stepa4man, thank you for the review.
|
I changed the source code. Please check it for me :) @Stepa4man |
Hi @dmytro-ch, thank you for the review.
|
✔️ QA passed |
@magento run all tests |
Hi @Stepa4man, thank you for the review. |
Hi @edenduong, thank you for your contribution! |
Description (*)
Solution: Check the condition, if the form doesn't have the "id", it should have label "Attribute Set Information"
Fixed Issues (if relevant)
Manual testing scenarios (*)
See the label:
Expected result
Should be:
Questions or comments
Contribution checklist (*)