Skip to content

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Comment "Warning!" in "Allow Symlinks" should have red color like other notices #24162: Comment "Warning!" in "Allow Symlinks" should have red color like other notices

Solution: Change the content in app/code/Magento/Backend/etc/adminhtml/system.xml

Fixed Issues (if relevant)

  1. Comment "Warning!" in "Allow Symlinks" should have red color like other notices #24162: Comment "Warning!" in "Allow Symlinks" should have red color like other notices

Manual testing scenarios (*)

  1. Go to backend
  2. Store->Configuration
  3. Advanced->Develop
  4. Template Settings, "Allow Symlinks"

See the comment : "Warning! Enabling this feature is not recommended on production environments because it represents a potential security risk."

Expected result

Warning should have red color: similar like (CSS Settings/Use CSS critical path)

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned kalpmehta Aug 18, 2019
@kalpmehta kalpmehta added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5665 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment "Warning!" in "Allow Symlinks" should have red color like other notices
5 participants