Skip to content

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve "HTTP Strict Transport Security" has the Outdate Url #24164: "HTTP Strict Transport Security" has the Outdate Url

Updated the url in app/code/Magento/Backend/etc/adminhtml/system.xml

Fixed Issues (if relevant)

  1. "HTTP Strict Transport Security" has the Outdate Url #24164: "HTTP Strict Transport Security" has the Outdate Url

Manual testing scenarios (*)

  1. Go to backend.
  2. Store->Configuration
  3. General->Web
  4. in Base URLs (Secure), "Use Secure URLs on Storefront" and "Use Secure URLs in Admin" : Yes
  5. Click the Url in "See HTTP Strict Transport Security page for details"

Expected result

  1. Go to CHEATSHEETS:

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5655 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@kalpmehta kalpmehta added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 18, 2019
@engcom-Delta engcom-Delta self-assigned this Aug 22, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"HTTP Strict Transport Security" has the Outdate Url
5 participants