Skip to content

Conversation

sudheer-gajjala
Copy link
Contributor

#24210 this is the url of the issue

Description (*)

Fixed Issues (if relevant)

  1. Toggle functionality for admin menu #24210: Toggle functionality for admin menu

Manual testing scenarios (*)

  1. Go to Magento Admin
    Click on the Menu Item (Ex Reports) Menu opens
    Again click on the Menu Item (Ex Reports) Menu closes

  2. No need to click on the close button to close the Menu.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2019

Hi @sudheer-gajjala. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 21, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sudheer Kumar Gajjala seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@ronak2ram ronak2ram self-assigned this Aug 22, 2019
@ronak2ram
Copy link
Member

@sudheer-gajjala thank you for the fixes!
Could you please squash all commits into a single one in order to clean up history?

@ronak2ram ronak2ram self-requested a review August 22, 2019 08:59
#24210 this is the url of the issue
@sudheer-gajjala
Copy link
Contributor Author

@sudheer-gajjala thank you for the fixes!
Could you please squash all commits into a single one in order to clean up history?
@ronak2ram completed squashing the commits.

@sudheer-gajjala
Copy link
Contributor Author

squashed to this commit "added fix for the ticket #24210" "fc87a57fffa759631f527be2831406779cc56f37"

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5695 has been created to process this Pull Request
✳️ @ronak2ram, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@sudheer-gajjala thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sudheer-gajjala
Copy link
Contributor Author

@magento-engcom-team I am unable to sign "Contributor License Agreement" could you please help me in this.

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 30, 2019

Hi @sudheer-gajjala, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 30, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants