Skip to content

Conversation

torhoehn
Copy link
Contributor

@torhoehn torhoehn commented Aug 23, 2019

Description (*)

Until now it wasn't possible to disable/enable swatch tooltips.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to Stores -> Settings -> Configuration -> Catalog -> Catalog -> Storefront
  2. Disable 'Show Swatch Tooltip'
  3. Swatch Tooltip isn't rendered anymore on catalog category view and catalog product view

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2019

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@torhoehn
Copy link
Contributor Author

torhoehn commented Sep 3, 2019

@engcom-Delta Could you please tell me where I should add a version change?

@ghost ghost assigned sidolov Sep 5, 2019
@josefbehr
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5851 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 16, 2019
@engcom-Delta engcom-Delta self-assigned this Sep 17, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Sep 19, 2019
@magento-engcom-team magento-engcom-team merged commit eff29c4 into magento:2.3-develop Sep 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 20, 2019

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 20, 2019
@torhoehn torhoehn deleted the feature/swatch-tooltip branch September 20, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants