Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Magento_Authorizenet ReadMe #24279

Merged
merged 3 commits into from
Sep 12, 2019
Merged

Update Magento_Authorizenet ReadMe #24279

merged 3 commits into from
Sep 12, 2019

Conversation

diazwatson
Copy link
Contributor

Description (*)

Updates ReadMe for the Magento_Authorizenet module.

Fixed Issues (if relevant)

  1. magento/devdocs README content for modules - work in M2 Code devdocs#4451: README content for modules - work in M2 Code

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 25, 2019

Hi @diazwatson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Authorizenet Release Line: 2.3 Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner labels Aug 25, 2019
app/code/Magento/Authorizenet/README.md Outdated Show resolved Hide resolved
app/code/Magento/Authorizenet/README.md Outdated Show resolved Hide resolved
app/code/Magento/Authorizenet/README.md Outdated Show resolved Hide resolved
app/code/Magento/Authorizenet/README.md Outdated Show resolved Hide resolved
@ghost ghost assigned jeff-matthews Aug 26, 2019
@jeff-matthews jeff-matthews added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @jeff-matthews, thank you for the review.
ENGCOM-5706 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Hi @diazwatson I think module description after # Magento_Authorizenet module header is not correct.
Could you take a look?

@diazwatson
Copy link
Contributor Author

@engcom-Delta many thanks for catching this 👍

@ihor-sviziev
Copy link
Contributor

Hi @jeff-matthews,
Could you review latest changes that were made by @diazwatson?

@magento-engcom-team
Copy link
Contributor

Hi @jeff-matthews, thank you for the review.
ENGCOM-5706 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 12, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Authorizenet Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants