Skip to content

Conversation

rani-priya
Copy link
Contributor

Resolved edit configurable product from cart doesn't show selected swatch options #24306

Description (*)

Fixed Issues (if relevant)

  1. Edit configurable product from cart doesn't show selected swatch options #24306: Edit configurable product from cart doesn't show selected swatch options

Manual testing scenarios (*)

  1. create a configurable product with more than one swatch attribute
  2. add product to cart
  3. then edit the same from cart

issue

@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2019

Hi @rani-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rani-webkul. Thanks for collaboration. Please check failed builds.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5716 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@rani-priya
Copy link
Contributor Author

Hi @VladimirZaets I think these failed builds are not related to this commit. Could you please check it once?

@rani-priya
Copy link
Contributor Author

@magento give me test instance
@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rani-webkul. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rani-webkul, here is your new Magento instance.
Admin access: https://pr-24308.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rani-priya
Copy link
Contributor Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rani-webkul. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rani-webkul, here is your Magento instance.
Admin access: https://i-24308-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rani-priya
Copy link
Contributor Author

Hi @VladimirZaets, I think these failed builds are not related to this commit. Could you please check it once?

@rani-priya
Copy link
Contributor Author

@VladimirZaets Please review again.

@ghost
Copy link

ghost commented Sep 4, 2019

@rani-webkul unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5716 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2019

Hi @rani-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 7, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants