Skip to content

resolve CData section too big on Export grid issue 24311 #24314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

resolve CData section too big on Export grid issue 24311 #24314

wants to merge 8 commits into from

Conversation

gaurangpadhiyar007
Copy link

@gaurangpadhiyar007 gaurangpadhiyar007 commented Aug 27, 2019 •
edited
Loading

Description (*)

Fixed Issues

  1. "CData section too big" on Export grid #24311: "CData section too big" error while accessing configurable product in backend

Manual testing scenarios (*)

  1. At export history grid number of files more (> 20000)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2019

Hi @gaurangpadhiyar007. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 27, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gaurangpadhiyar007 gaurangpadhiyar007 mentioned this pull request Aug 27, 2019
Closed
@Stepa4man
Copy link
Contributor

@magento run all tests

@gaurangpadhiyar007
Copy link
Author

@magento area adminhtml

@gaurangpadhiyar007 gaurangpadhiyar007 mentioned this pull request Aug 28, 2019
Closed
@gaurangpadhiyar007
Copy link
Author

@magento-cicd2 @magento-admin run area adminhtml

@magento-cicd2 @magento-admin run all tests

@gaurangpadhiyar007
Copy link
Author

@magento run area adminhtml
@magento run all tests

@rodrigowebjump
Copy link
Member

Hi @gaurangpadhiyar007 Please,
Thanks for your contribution.
I kindly ask you to add an appropriate description and tests scenarios to your PR.

Please, do not forget to review the failing tests.

Thanks
Thanks

@gaurangpadhiyar007
Invalid arguments solved
642e3dd 
Magento XML schema validation issue solved
@gaurangpadhiyar007
Pagination Issue and basename warning solved
4fe6cca 
Pagination issue resolved
function basename warning resolved
gaurangpadhiyar007
gaurangpadhiyar007 commented Sep 4, 2019
View reviewed changes
Copy link
Author

@gaurangpadhiyar007 gaurangpadhiyar007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue of merging run test solved

@gaurangpadhiyar007
Merge issue due to params resolved
fe4c5cf 
$meta parameter is not in order
@param is not found for one or more params in method annotation
$fileIO parameter is missing in method annotation
@gaurangpadhiyar007
Merging issue of ui xml validation resolved
62f6270 
This node should migrate to "settings/sticky"
This node should migrate to "settings/selectProvider"
This node should migrate to "settings/storageConfig"
@gaurangpadhiyar007
Update export_grid.xml
326cfef
@gaurangpadhiyar007
Update export_grid.xml
8bec22c
@gaurangpadhiyar007
Avoid unused private fields such as $fileIO
a21f0c2
@gaurangpadhiyar007
Copy link
Author

@rodrigowebjump
I have made all changes as per given errors but as I solve them new un-neccessary errors are generating by Automated testing tool, Please test the commit on Magento instance.

sidolov
sidolov requested changes Sep 20, 2019
View reviewed changes
app/code/Magento/ImportExport/Ui/DataProvider/ExportFileDataProvider.php
@@ -51,11 +60,14 @@ public function __construct(
\Magento\Framework\Api\FilterBuilder $filterBuilder,
DriverInterface $file,
Filesystem $filesystem,
File $fileIO,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, inject new dependencies according to our Backward Compatible Development Guide

@ghost ghost assigned sidolov Sep 20, 2019
@sidolov
Copy link
Contributor

sidolov commented Oct 4, 2019

@gaurangpadhiyar007 I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Oct 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 4, 2019

Hi @gaurangpadhiyar007, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov requested changes

@rodrigowebjump rodrigowebjump Awaiting requested review from rodrigowebjump

Assignees

@sidolov sidolov

Labels
Area: Frontend Component: ImportExport Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaurangpadhiyar007 @magento-cicd2 @Stepa4man @rodrigowebjump @sidolov @magento-engcom-team