Skip to content

Conversation

sergey-solo
Copy link
Contributor

@sergey-solo sergey-solo commented Aug 28, 2019

Description (*)

Xml attributes needed to be encoded to allow special symbols such as &.

Fixed Issues (if relevant)

  1. Problem with adding google fonts with ampersand into default_head_blocks.xml  #2228 Problem with adding google fonts with ampersand into default_head_blocks.xml

Manual testing scenarios (*)

  1. Per Problem with adding google fonts with ampersand into default_head_blocks.xml  #2228, add the following to add a link to a page using the following code. The exception shouldn't be thrown.
<link src="//fonts.googleapis.com/css?family=Open+Sans|Roboto+Condensed|Open+Sans+Condensed:400,300,300italic,400italic,600,600italic,700italic,700&amp;subset=latin,cyrillic" src_type="url" />

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 28, 2019

Hi @sergey-solo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets
Copy link
Contributor

@magento run all tests

@rodrigowebjump
Copy link
Member

Hi @sergey-solo

Please could you check the failing test?

Regards

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-5761 has been created to process this Pull Request
✳️ @rodrigowebjump, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @sergey-solo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 5, 2019
@sergey-solo sergey-solo deleted the m2-github-issue/2228 branch September 6, 2019 13:09
@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants