Skip to content

Fix for bug: If multiple children had the same sort order only one of… #24457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

oskarolaussen
Copy link
Contributor

… them would be rendered

Description (*)

Changed Magento\Catalog\Block\Product\View\Details to fix issue with multiple children having the same sort order causing only one of them to render.

Fixed Issues (if relevant)

If you have multiple tabs on product page with the same sort order or without sort order only one of them will render.

Manual testing scenarios (*)

Have multiple tabs on product page with the same sort order.
Before fix: only one is rendered.
After: All of them are rendered.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @oskarolaussen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned swnsma Sep 5, 2019
@swnsma swnsma added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix labels Sep 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5787 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2019

Hi @oskarolaussen, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Karlasa
Copy link
Contributor

Karlasa commented Sep 17, 2019

linked to issue #24474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants