-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[SalesRule] Covering the CouponCodeValidation class by Unit Tests #24516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SalesRule] Covering the CouponCodeValidation class by Unit Tests #24516
Conversation
Hi @eduard13. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, @eduard13!
Could you please fix minor recommendations reported by Static Test?
Thank you!
Hi @dmytro-ch, the Static Tests were fixed. |
Hi @dmytro-ch, thank you for the review.
|
Notice: QA not applicable |
Hi @eduard13, thank you for your contribution! |
Description (*)
This PR covers the
\Magento\SalesRule\Observer\CouponCodeValidation
observer class by Unit Tests, that is used for validating the newly provided coupon code before using it while calculating totals.Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Questions or comments
Contribution checklist (*)