Skip to content

Conversation

edenduong
Copy link
Contributor

Description (*)

API "V1/attributeMetadata/customerAddress/attribute/prefix" and "V1/attributeMetadata/customerAddress/attribute/suffix" can not get options

The reason because Prefix and Suffix get the Option from SYSTEM CONFIG, not in SOURCE

Fixed Issues (if relevant)

  1. API "V1/attributeMetadata/customerAddress/attribute/prefix" and "V1/attributeMetadata/customerAddress/attribute/suffix" can not get options #24518: API "V1/attributeMetadata/customerAddress/attribute/prefix" and "V1/attributeMetadata/customerAddress/attribute/suffix" can not get options

Manual testing scenarios (*)

  1. Go to backend, Store->Configuration. Customer Configuration.

In "Name and Address Options", "Show Prefix": "Optional". "Prefix Dropdown Options" is "mr;mrs"

Similar to Suffix.

  1. Use Postman or Rest Client to create API request
  2. Request to http://[Magento 2 Domain] /rest/default/V1/integration/admin/token to get TOKEN
  3. Use the token to call the api:

http://[Magento 2 Domain] /rest/default/V1/attributeMetadata/customerAddress/attribute/prefix

Similar to Suffix:

http://[Magento 2 Domain] /rest/default/V1/attributeMetadata/customerAddress/attribute/suffix

Expected result

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from paliarush as a code owner September 8, 2019 15:10
@m2-assistant
Copy link

m2-assistant bot commented Sep 8, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

…nd "V1/attributeMetadata/customerAddress/attribute/suffix" can not get options issue24518
@edenduong edenduong force-pushed the 2.3-bugfix/getoption_suffix_prefix_issue24518 branch from 1427570 to 1da4f2a Compare September 9, 2019 06:21
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5821 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

magento-engcom-team pushed a commit that referenced this pull request Sep 12, 2019
…ute/prefix" and "V1/attributeMetadata/customerAddress/attribute/suffix" can not get options #24519
@magento-engcom-team magento-engcom-team merged commit e779423 into magento:2.3-develop Sep 12, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants