Skip to content

Conversation

mohith227
Copy link
Contributor

Description (*)

Auto select configurable attribute value in the product view page of the configurable product

Fixed Issues (if relevant)

  1. configurable product's associate are not selected by default for attributes default values #24496: configurable product's associate are not selected by default for attributes default values

Manual testing scenarios (*)

  1. Click on configurable product in the product listing page the swatch options will be auto selected in the product view page

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@mohith227 mohith227 requested a review from DrewML as a code owner September 13, 2019 19:56
@m2-assistant
Copy link

m2-assistant bot commented Sep 13, 2019

Hi @mohith227. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:20
@krzksz
Copy link
Contributor

krzksz commented Dec 8, 2019

Hey @mohith227, can you take a look at conflicts and failing tests? Thanks!

@Bartlomiejsz
Copy link
Contributor

Hi @mohith227, I believe for some reason this PR reverts changes from #24255 - this shouldn't happen i think

@lenaorobei
Copy link
Contributor

Closing this PR due to inactivity.
@mohith227 please feel free to reopen it if you plan to continue working on it. Please address comments from @krzksz and @Bartlomiejsz. Thanks.

@lenaorobei lenaorobei closed this Feb 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2020

Hi @mohith227, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants