Skip to content

Added description discount for each summary(cart, order) #24595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 26, 2019

Conversation

MaxSouza
Copy link
Contributor

Description (*)

Added description discount for each summary(cart, order)

Fixed Issues (if relevant)

  1. Discount Description does not get displayed on cart page #3594: Discount Description does not get displayed on cart page

Manual testing scenarios (*)

  1. Create a coupon with description
  2. Add product to cart and apply coupon
  3. Check if discount description is displayed on summary

Questions or comments

image
image

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@MaxSouza MaxSouza requested a review from akaplya as a code owner September 14, 2019 17:10
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2019

Hi @MaxSouza. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@kalpmehta kalpmehta self-assigned this Sep 14, 2019
@kalpmehta
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, here is your Magento instance.
Admin access: https://i-24595-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@kalpmehta
Copy link
Contributor

@MaxSouza I don't think this is an issue. Showing shopping cart rule description may not work for everybody. Some merchants are using it for internal purpose, some might have quite bigger description text which cannot fit in the cart totals box. This is more like a workaround for the merchants who want to use description field to display some kind of message near the discount label.

@MaxSouza
Copy link
Contributor Author

@kalpmehta Can you comment on issue, please?

@kalpmehta
Copy link
Contributor

Sure @MaxSouza. Thank you for your contribution. I will comment on the issue and will also wait for some other reviewer if they think otherwise.

@kalpmehta
Copy link
Contributor

@MaxSouza Can you please fix the space issues and add the tests?

@MaxSouza
Copy link
Contributor Author

@kalpmehta I'm working on tests

@josefbehr josefbehr self-assigned this Sep 19, 2019
@MaxSouza MaxSouza requested a review from kalpmehta September 20, 2019 14:14
@kalpmehta
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, here is your new Magento instance.
Admin access: https://pr-24595.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@kalpmehta kalpmehta added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5926 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2019

Hi @MaxSouza, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 26, 2019
@josefbehr josefbehr removed their assignment Sep 26, 2019
@aman3103
Copy link
Contributor

@magento-engcom-team I don't think this is a good change to show the coupon description in admin also as customer care team then don't have any information about which code is applied as in coupon code field also they don't have way to filter the code using description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants