-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Added description discount for each summary(cart, order) #24595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @MaxSouza. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me 2.3-develop instance |
Hi @kalpmehta. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @kalpmehta, here is your Magento instance. |
@MaxSouza I don't think this is an issue. Showing shopping cart rule description may not work for everybody. Some merchants are using it for internal purpose, some might have quite bigger description text which cannot fit in the cart totals box. This is more like a workaround for the merchants who want to use description field to display some kind of message near the discount label. |
@kalpmehta Can you comment on issue, please? |
Sure @MaxSouza. Thank you for your contribution. I will comment on the issue and will also wait for some other reviewer if they think otherwise. |
@MaxSouza Can you please fix the space issues and add the tests? |
@kalpmehta I'm working on tests |
@magento give me test instance |
Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you |
Hi @kalpmehta, here is your new Magento instance. |
Hi @kalpmehta, thank you for the review. |
✔️ QA passed |
Hi @MaxSouza, thank you for your contribution! |
@magento-engcom-team I don't think this is a good change to show the coupon description in admin also as customer care team then don't have any information about which code is applied as in coupon code field also they don't have way to filter the code using description. |
Description (*)
Added description discount for each summary(cart, order)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)