Skip to content

Fix whats this scroll top #24602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 26, 2019
Merged

Fix whats this scroll top #24602

merged 4 commits into from
Sep 26, 2019

Conversation

vinidziuba
Copy link

@vinidziuba vinidziuba commented Sep 14, 2019 •
edited
Loading

Description (*)

Solution : changed the tag for the strong tag and took the href.

Fixed Issues (if relevant)

  1. Click "What 's this" link scroll to the top of page #24511: Click "What 's this" link scroll to the top of page

Manual testing scenarios (*)

  1. Go to backend
    Store->Configuration->Customer->Persistent Shopping Cart->Enable Persistence to Yes.
  2. Go to Frontend, Sign In
  3. In Remember me, click "What's this?" link

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2019

Hi @vinidziuba. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@kalpmehta kalpmehta self-assigned this Sep 15, 2019
kalpmehta
kalpmehta requested changes Sep 15, 2019
View reviewed changes
Copy link
Contributor

@kalpmehta kalpmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinidziuba Please fix all the space issues in the PR

kalpmehta
kalpmehta requested changes Sep 15, 2019
View reviewed changes
magento#24511:Click "What 's this" link scroll to the top of page
397ce47 
- changed the tag for the strong tag and took the href.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

vinidziuba
vinidziuba commented Sep 23, 2019
View reviewed changes
Copy link
Author

@vinidziuba vinidziuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@ghost ghost assigned sidolov Sep 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5935 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@vinidziuba thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5935 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Sep 24, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 24, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 24, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Sep 26, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Sep 26, 2019
@sidolov
ENGCOM-5935: Fix whats this scroll top #24602
7b6bb8a
@magento-engcom-team magento-engcom-team merged commit 397ce47 into magento:2.3-develop Sep 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2019

Hi @vinidziuba, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 26, 2019
@vinidziuba vinidziuba added partners-contribution Pull Request is created by Magento Partner Partner: Híbrido Pull Request is created by partner Híbrido labels Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalpmehta kalpmehta kalpmehta approved these changes

@sidolov sidolov sidolov approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@kalpmehta kalpmehta

@sidolov sidolov

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Persistent Partner: Híbrido Pull Request is created by partner Híbrido partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@vinidziuba @magento-cicd2 @magento-engcom-team @engcom-Delta @kalpmehta @sidolov @engcom-Foxtrot