Skip to content

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve No error message when click "Import Tax Rates" without select file #24642: No error message when click "Import Tax Rates" without select file

Fixed Issues (if relevant)

  1. No error message when click "Import Tax Rates" without select file #24642: No error message when click "Import Tax Rates" without select file

Manual testing scenarios (*)

  1. Go to backend
  2. System->Import & Export Tax Rates
  3. Click "Import Tax Rates" without select file

Expected result

  1. The error message is alerted

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from akaplya as a code owner September 18, 2019 10:39
@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-5860 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 19, 2019
@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 19, 2019
magento-engcom-team pushed a commit that referenced this pull request Sep 20, 2019
@magento-engcom-team magento-engcom-team merged commit 77562da into magento:2.3-develop Sep 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 20, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error message when click "Import Tax Rates" without select file
6 participants