Skip to content

refactor deployment config reader, change inconsistent load method to… #24692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2019
Merged

refactor deployment config reader, change inconsistent load method to… #24692

merged 2 commits into from
Oct 15, 2019

Conversation

georgebabarus
Copy link
Contributor

Description (*)

Method \Magento\Framework\App\DeploymentConfig\Reader::load is not consistent with constructor.
The constructor is initializing the files member, but it is not used when loading configuration.

Manual testing scenarios (*)

The configuration should work the same after deploying this changes.

@m2-assistant
Copy link

m2-assistant bot commented Sep 22, 2019

Hi @georgebabarus. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@georgebabarus georgebabarus changed the title refactor deployment config reader, remove inconsistent load method to… refactor deployment config reader, change inconsistent load method to… Sep 22, 2019
@georgebabarus georgebabarus marked this pull request as ready for review September 23, 2019 08:01
@orlangur orlangur self-assigned this Sep 23, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 26, 2019
@VladimirZaets VladimirZaets self-assigned this Sep 26, 2019
orlangur
orlangur reviewed Sep 26, 2019
View reviewed changes
lib/internal/Magento/Framework/App/DeploymentConfig/Reader.php Outdated
$configFile = $path . '/' . $this->configFilePool->getPath($fileKey);
$configFiles = $this->getFiles();
foreach ($configFiles as $file) {
$configFile = $path . DIRECTORY_SEPARATOR . $file;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use '/' instead as it was before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ghost ghost assigned sidolov Oct 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-6010 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@georgebabarus thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta engcom-Delta self-assigned this Oct 10, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 10, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 15, 2019
@VladimirZaets
ENGCOM-6010: refactor deployment config reader, change inconsistent l…
9f2822b 
…oad method to… #24692
@magento-engcom-team magento-engcom-team merged commit 62ac658 into magento:2.3-develop Oct 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2019

Hi @georgebabarus, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 15, 2019
@georgebabarus georgebabarus deleted the deployment-config-reader branch September 27, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur left review comments

@sidolov sidolov sidolov approved these changes

@buskamuza buskamuza Awaiting requested review from buskamuza

Assignees

@orlangur orlangur

@VladimirZaets VladimirZaets

@sidolov sidolov

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: App Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@georgebabarus @magento-engcom-team @engcom-Delta @engcom-Foxtrot @orlangur @sidolov @VladimirZaets