Skip to content

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Suggested Terms Yes/No not in camel case #24739: Suggested Terms Yes/No not in camel case

Fixed Issues (if relevant)

  1. Suggested Terms Yes/No not in camel case #24739: Suggested Terms Yes/No not in camel case

Manual testing scenarios (*)

  1. Admin -> Marketing
  2. SEO & Search -> Search Terms
  3. Review the Suggested Terms drop-down text

Expected Result
It should display in camel case as Yes/No

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from kokoc as a code owner September 27, 2019 07:07
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5958 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 28, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested Terms Yes/No not in camel case
5 participants