Skip to content

Conversation

DanielRuf
Copy link
Contributor

Description (*)

This PR fixes the wrong boolean check which was always failing / false.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@DanielRuf DanielRuf requested a review from DrewML as a code owner October 4, 2019 08:23
@m2-assistant
Copy link

m2-assistant bot commented Oct 4, 2019

Hi @DanielRuf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf engcom-Golf self-assigned this Oct 8, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 8, 2019
@magento-engcom-team magento-engcom-team merged commit 70379ee into magento:2.3-develop Oct 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 14, 2019

Hi @DanielRuf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 14, 2019
@DanielRuf DanielRuf deleted the fix/correct-boolean-check branch October 14, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants