Skip to content

Remove useless aliases for imports #24871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Remove useless aliases for imports #24871

merged 2 commits into from
Oct 23, 2019

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Oct 5, 2019

Description (*)

Remove useless aliases for imports.

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Not necessary

Questions or comments

Unfortunately, we don't have such rule in https://github.com/FriendsOfPHP/PHP-CS-Fixer to add to our .php_cs.dist 😕

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 5, 2019

Hi @carusogabriel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@carusogabriel
Copy link
Contributor Author

@ghost ghost assigned josefbehr Oct 21, 2019
@josefbehr josefbehr added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 21, 2019
@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-6140 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit 3e33815 into magento:2.3-develop Oct 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @carusogabriel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 23, 2019
@carusogabriel carusogabriel deleted the style/remove-useless-alias branch October 23, 2019 14:40
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Acl Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Component: Controller Component: ObjectManager Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants