Static Content Deploy - Get rid of in_array(array_keys($array))

[andrey-legayev]

Description (*)

Performance fix - Replace in_array(array_keys($array)) by isset($array)

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

None

Questions or comments

I understand that adding public methods isn't great, but doing in_array(array_keys($array)) isn't cool from performance point of view.
If it's absolutely not possible to add it to 2.3 then please take it to 2.4.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @andrey-legayev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[VladimirZaets]

Hi @andrey-legayev. Thanks for collaboration. It's not API class, so we can add new public method here, this is ok.

Can you please che

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-6035 has been created to process this Pull Request

[andrey-legayev]

@VladimirZaets you didn't finish sentence: Can you please che...

[engcom-Bravo]

✔️ QA passed

[m2-assistant]

Hi @andrey-legayev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.