Skip to content

Conversation

korostii
Copy link
Contributor

@korostii korostii commented Oct 9, 2019

Description (*)

Update $this->patchesRegistry in real-time in order to prevent patches from being applied multiple times.
Consecutively, \Magento\Framework\Setup\Patch\PatchRegistry::registerPatch() will recognize that these patches were previously applied through a $this->patchHistory->isApplied($patchName) call.

Fixed Issues (if relevant)

  1. Declarative schema: Patch dependencies can cause a patch to apply twice #24019: Declarative schema: Patch dependencies can cause a patch to apply twice

Manual testing scenarios (*)

Please see #24019 for detailed steps.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Update $this->patchesRegistry in realtime in order to prevent patches from neing applied multiple times.
@korostii korostii requested a review from buskamuza as a code owner October 9, 2019 14:15
@m2-assistant
Copy link

m2-assistant bot commented Oct 9, 2019

Hi @korostii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@korostii korostii force-pushed the korostii-patch-24019 branch from ba69fa2 to 5632f45 Compare October 9, 2019 17:42
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @korostii. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.

@ghost ghost assigned VladimirZaets Oct 9, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 9, 2019
@korostii korostii removed the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 11, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6198 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

magento-engcom-team pushed a commit that referenced this pull request Nov 4, 2019
@magento-engcom-team magento-engcom-team merged commit 3d6690a into magento:2.3-develop Nov 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 4, 2019

Hi @korostii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants