-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix #24019 #24947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #24019 #24947
Conversation
Update $this->patchesRegistry in realtime in order to prevent patches from neing applied multiple times.
Hi @korostii. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
ba69fa2
to
5632f45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @korostii. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.
Hi @VladimirZaets, thank you for the review. |
Hi @korostii, thank you for your contribution! |
Description (*)
Update
$this->patchesRegistry
in real-time in order to prevent patches from being applied multiple times.Consecutively,
\Magento\Framework\Setup\Patch\PatchRegistry::registerPatch()
will recognize that these patches were previously applied through a$this->patchHistory->isApplied($patchName)
call.Fixed Issues (if relevant)
Manual testing scenarios (*)
Please see #24019 for detailed steps.
Questions or comments
Contribution checklist (*)