Skip to content

Conversation

eduard13
Copy link
Contributor

Description (*)

This PR changes the delete confirmation type while removing the Tracking Number, by using the confirm widget instead the browser one.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. Create a new order
  2. Create a shipment for that order
  3. Navigate to the shipment
  4. Add a new tracking carrier
  5. Remove the tracking number

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 requested a review from YevSent as a code owner October 16, 2019 13:04
@m2-assistant
Copy link

m2-assistant bot commented Oct 16, 2019

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 16, 2019
@rogyar rogyar self-assigned this Oct 16, 2019
@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels Oct 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6108 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Shipping Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants