Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translate for strings and added missing node in existing translate attribute on xml. #25114

Merged

Conversation

sanganinamrata
Copy link
Member

Description (*)

  • Added missing translate for strings specified in XML files.
  • Added missing node in the existing translate attribute in XML.

Fixed Issues (if relevant)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 17, 2019

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sanganinamrata
Copy link
Member Author

@osrecio Hi, It's been 7 days now, still my PR is not merged. Any issue with it?

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:18
@ghost ghost assigned krzksz Dec 9, 2019
@engcom-Alfa engcom-Alfa self-assigned this Dec 12, 2019
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 12, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@ghost ghost added the Progress: accept label Dec 13, 2019
magento-engcom-team pushed a commit that referenced this pull request Dec 16, 2019
@magento-engcom-team magento-engcom-team merged commit 61580f4 into magento:2.4-develop Dec 16, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2019

Hi @sanganinamrata, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants