Skip to content

#25214 fixed #25215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Oct 26, 2019
Merged

#25214 fixed #25215

merged 1 commit into from Oct 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2019

Description (*)

Fixed Issues (if relevant)

  1. Garbage code issue #25214: Garbage code issue

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ghost ghost requested a review from paliarush as a code owner October 22, 2019 13:02
@m2-assistant
Copy link

m2-assistant bot commented Oct 22, 2019

Hi @vishesh-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Oct 22, 2019
@dmytro-ch
Copy link
Contributor

The PR is on hold until the issue is confirmed.

@engcom-Bravo engcom-Bravo self-assigned this Oct 23, 2019
@engcom-Foxtrot engcom-Foxtrot added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 23, 2019
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 25, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2019

Hi @vishesh-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Oct 26, 2019
@VladimirZaets
ENGCOM-6154: #25214 fixed #25215
6485e54
@magento-engcom-team magento-engcom-team merged commit 9af76e7 into magento:2.3-develop Oct 26, 2019
@engcom-Delta engcom-Delta mentioned this pull request Oct 28, 2019
Closed
@ghost ghost mentioned this pull request Nov 20, 2019
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@dmytro-ch dmytro-ch

@engcom-Bravo engcom-Bravo

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytro-ch @engcom-Bravo @magento-engcom-team @engcom-Foxtrot