-
Notifications
You must be signed in to change notification settings - Fork 9.4k
upgrade method delete by ids to inject array skus #25249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade method delete by ids to inject array skus #25249
Conversation
Hi @sarron93. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarron93. Thanks for collaboration.
Please take a look at review comments.
@sarron93 your changes are also backward incompatible. In this case, you should create an interface with just one method and implement is in this class |
@VladimirZaets, Hello, all changes are ready |
@sarron93 Hi, can you please rename your interface to "CategoryListDeleteBySkuInterface.php |
|
@sarron93 thank you |
Hi @VladimirZaets, thank you for the review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarron93,
Could you add preference for new interface to di.xml file?
All tests were passing, so that should be it.
Nazar tried to do that, but didn’t succeed with it.
@sarron93 thank you a lot 👍 |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
Hi @sarron93, thank you for your contribution! |
Description (*)
when I call the deleteByIds method in the Magento \ Catalog \ Model \ CategoryLinkRepository class, I expect the sku array to be the second parameter to quickly remove products from the category, but I get the deletion only one at a time. Method name - does not match its functionality
Contribution checklist (*)