Skip to content

upgrade method delete by ids to inject array skus #25249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 13, 2020
Merged

upgrade method delete by ids to inject array skus #25249

merged 14 commits into from
Feb 13, 2020

Conversation

sarron93
Copy link
Member

Description (*)

when I call the deleteByIds method in the Magento \ Catalog \ Model \ CategoryLinkRepository class, I expect the sku array to be the second parameter to quickly remove products from the category, but I get the deletion only one at a time. Method name - does not match its functionality

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sarron93 sarron93 requested a review from akaplya as a code owner October 23, 2019 16:42
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @sarron93. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sarron93. Thanks for collaboration.
Please take a look at review comments.

@VladimirZaets
Copy link
Contributor

@sarron93 your changes are also backward incompatible. In this case, you should create an interface with just one method and implement is in this class

@sarron93
Copy link
Member Author

sarron93 commented Dec 1, 2019

@sarron93 your changes are also backward incompatible. In this case, you should create an interface with just one method and implement is in this class

@VladimirZaets, Hello, all changes are ready

@VladimirZaets
Copy link
Contributor

@sarron93 Hi, can you please rename your interface to "CategoryListDeleteBySkuInterface.php

@sarron93
Copy link
Member Author

sarron93 commented Dec 2, 2019

@sarron93 Hi, can you please rename your interface to "CategoryListDeleteBySkuInterface.php
@VladimirZaets Hi, ready :)

@VladimirZaets
Copy link
Contributor

@sarron93 thank you

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6379 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@sarron93 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17
@engcom-Alfa engcom-Alfa self-assigned this Dec 6, 2019
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sarron93,
Could you add preference for new interface to di.xml file?
All tests were passing, so that should be it.
Nazar tried to do that, but didn’t succeed with it.

@sarron93 sarron93 requested a review from ihor-sviziev February 7, 2020 17:55
@engcom-Golf
Copy link
Contributor

@sarron93 thank you a lot 👍

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6829 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @sarron93, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants