Skip to content

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 24, 2019

Description

  • Fixed improper usage of ObjectManager
  • Removed unnecessary method: getCssProcessor()
  • Fixed appropriate PHPUnit tests

Manual testing scenarios

  • ONLY code change

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne drpayyne requested a review from melnikovi as a code owner October 24, 2019 09:04
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2019

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Oct 24, 2019
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Oct 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6176 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants