Skip to content

Fixes unstable email integration tests, by decoding the raw contents … #25296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fixes unstable email integration tests, by decoding the raw contents … #25296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/tests/integration/testsuite/Magento/Newsletter/Model/SubscriberTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public function testConfirm()

$this->assertContains(
'You have been successfully subscribed to our newsletter.',
$transportBuilder->getSentMessage()->getRawMessage()
$transportBuilder->getSentMessage()->getBody()->getParts()[0]->getRawContent()
);
}
}
2 changes: 1 addition & 1 deletion dev/tests/integration/testsuite/Magento/ProductAlert/Model/EmailTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public function testSend($isCustomerIdUsed)

$this->assertContains(
'John Smith,',
$this->transportBuilder->getSentMessage()->getRawMessage()
$this->transportBuilder->getSentMessage()->getBody()->getParts()[0]->getRawContent()
);
}

Expand Down
4 changes: 2 additions & 2 deletions dev/tests/integration/testsuite/Magento/ProductAlert/Model/ObserverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function testProcess()
$this->observer->process();
$this->assertContains(
'John Smith,',
$this->transportBuilder->getSentMessage()->getRawMessage()
$this->transportBuilder->getSentMessage()->getBody()->getParts()[0]->getRawContent()
);
}

Expand Down Expand Up @@ -117,7 +117,7 @@ public function testProcessPortuguese()

// dispatch process() method and check sent message
$this->observer->process();
$message = $this->transportBuilder->getSentMessage()->getRawMessage();
$message = $this->transportBuilder->getSentMessage()->getBody()->getParts()[0]->getRawContent();
$expectedText = array_shift($translation);
$this->assertContains('/frontend/Magento/luma/pt_BR/', $message);
$this->assertContains(substr($expectedText, 0, 50), $message);
Expand Down
2 changes: 1 addition & 1 deletion dev/tests/integration/testsuite/Magento/Wishlist/Controller/IndexTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public function testSendAction()
\Magento\TestFramework\Mail\Template\TransportBuilderMock::class
);

$actualResult = quoted_printable_decode($transportBuilder->getSentMessage()->getRawMessage());
$actualResult = $transportBuilder->getSentMessage()->getBody()->getParts()[0]->getRawContent();

$this->assertStringMatchesFormat(
'%A' . $this->_customerViewHelper->getCustomerName($this->_customerSession->getCustomerDataObject())
Expand Down